Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimodal patches #971

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Multimodal patches #971

merged 14 commits into from
Sep 18, 2024

Conversation

RaynorChavez
Copy link
Member

@RaynorChavez RaynorChavez commented Sep 17, 2024 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug Fix/improvements

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    Fix a bug where when treatUrlsAndPointersAsImages is unset and treatUrlsAndPointersAsMedia is set, Marqo returns an error where treatUrlsAndPointersAsImages cannot be False when treatUrlsAndPointersAsMedia is True
    Add new video-audio model LanguageBind/Video_V1.5_FT_Audio_FT to the model registry.
    Move languagebind tests from CPU to CUDA tests

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:
    Related marqo-api-tests PR: move languagebind tests to cuda marqo-api-tests#96
    Related manual api tests runs

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@RaynorChavez RaynorChavez changed the title Fix multimodal patches Multimodal patches Sep 17, 2024
papa99do
papa99do previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@papa99do papa99do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

papa99do
papa99do previously approved these changes Sep 18, 2024
View reviewed changes
@RaynorChavez RaynorChavez merged commit a0084a8 into mainline Sep 18, 2024
12 of 13 checks passed
@RaynorChavez RaynorChavez deleted the raynor/multimodal_patches branch September 18, 2024 06:19
adityabharadwaj198 pushed a commit to adityabharadwaj198/marqo that referenced this pull request Oct 10, 2024
@RaynorChavez @adityabharadwaj198
Multimodal patches (marqo-ai#971)
735f3d2 
- Fix a bug where when treatUrlsAndPointersAsImages is unset and treatUrlsAndPointersAsMedia is set, Marqo returns an error where treatUrlsAndPointersAsImages cannot be False when treatUrlsAndPointersAsMedia is True
- Add new video-audio model LanguageBind/Video_V1.5_FT_Audio_FT to the model registry.
- Move languagebind tests from CPU to CUDA tests
- Change audioPreprocessing chunk length from 20 to 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papa99do papa99do papa99do approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaynorChavez @papa99do