add new fieldtypes for dict score modifiers #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Jun 28, 2024
| @@ -97,7 +97,7 @@ def test_valid_score_modifiers_format(self): | |||
| "add_to_score": [ | |||
| {"field_name": "add_1", "weight" : -3, | |||
| }, | |||
| {"field_name": "add_2", "weight": 1, | |||
| {"field_name": "add_2.a", "weight": 1, | |||
| }] | |||
| } | |||
| self.search_with_score_modifier(score_modifiers=valid_score_modifiers) | |||
There was a problem hiding this comment.
There's no assertion in this test. what is the expected behaviour?
papa99do
reviewed
Jun 28, 2024
| "add_to_score": [ | ||
| {"field_name": "add_1", "weight" : 4, | ||
| }, | ||
| {"field_name": "add_2", "weight": 1, | ||
| {"field_name": "add_2.a", "weight": 1, | ||
| }] | ||
| } | ||
|
|
There was a problem hiding this comment.
I think the assertion for this test is too wide. we should at least test the error code and some key word in the response if there's any
papa99do
reviewed
Jun 28, 2024
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Jul 1, 2024
|
|
||
| # NOTE: This isn't used anywhere |
There was a problem hiding this comment.
So why do we need this if it's not used in any places?
There was a problem hiding this comment.
I didn't totally remove def supported_marqo_version() yet as someone might have a comment on its use.
__marqo_version__ is removed though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
No
FieldTypesdefined for map score modifiersWhat is the new behavior (if this is a feature change)?
Added 4 new map numeric fieldtypes for dictionary score modifiers. Removed superfluour
__marqo_version__variableDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: