Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client test setup bug #275

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix client test setup bug #275

merged 2 commits into from
Feb 10, 2025

Conversation

vicilliar
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    client tests and all succeeding tests fail because MARQO_CLOUD_URL is set to the wrong URL in tearDown.

  • What is the new behavior (if this is a feature change)?
    Properly save existing MARQO_CLOUD_URL in setUp then returning it in tearDown.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@vicilliar vicilliar merged commit 692ee88 into mainline Feb 10, 2025
25 of 26 checks passed
@vicilliar vicilliar deleted the joshua/gcp-tests branch February 10, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants