Workspace UI will not load if historyRoles or operationRoles is undef…

…ined Fixes microsoft#3755
marrobi · Oct 18, 2023 · 42d7a26 · 42d7a26
1 parent 80e5268
commit 42d7a26
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ BUG FIXES:
 * Upgrade porter version to v1.0.15 and on error getting porter outputs return dict ([#3744](https://github.com/microsoft/AzureTRE/issues/3744))
 * Fix notifications displaying workspace name rather than actual resource ([#3746](https://github.com/microsoft/AzureTRE/issues/3746))
 * Fix SecuredByRole fails if app roles are not loaded  ([#3752](https://github.com/microsoft/AzureTRE/issues/3752))
+* Fix workspace not loading fails if operation or history roles are not loaded  ([#3755](https://github.com/microsoft/AzureTRE/issues/3755))
+
 
 COMPONENTS:
 

diff --git a/ui/app/package.json b/ui/app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tre-ui",
-  "version": "0.5.14",
+  "version": "0.5.15",
   "private": true,
   "dependencies": {
     "@azure/msal-browser": "^2.35.0",

diff --git a/ui/app/src/components/shared/ResourceBody.tsx b/ui/app/src/components/shared/ResourceBody.tsx
@@ -61,15 +61,15 @@ export const ResourceBody: React.FunctionComponent<ResourceBodyProps> = (props:
         </PivotItem>
       }
       {
-        !props.readonly &&
+        !props.readonly && historyRoles &&
         <PivotItem headerText="History">
           <SecuredByRole allowedAppRoles={historyRoles} allowedWorkspaceRoles={historyRoles} workspaceId={workspaceId} errorString={`Must have ${historyRoles.join(" or ")} role`} element={
             <ResourceHistoryList resource={props.resource} />
           } />
         </PivotItem>
       }
       {
-        !props.readonly &&
+        !props.readonly && operationsRoles &&
         <PivotItem headerText="Operations">
           <SecuredByRole allowedAppRoles={operationsRoles} allowedWorkspaceRoles={operationsRoles} workspaceId={workspaceId} errorString={`Must have ${operationsRoles.join(" or ")} role`} element={
             <ResourceOperationsList resource={props.resource} />