Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_packages
use has been deprecated? If this corrects the file ending issue that line number mapping triggers, there may be a larger issue?Official documentation doesn't suggest using this function, which was an older Python 2 approach and theoretical way to "save time" back when it was most typical to have an executable
setup.py
script invokingsetuptools
. (See also: old-style namespaces which have a__init__.py
files declaring the namespace. See this documentation for a complete description of "native namespace packages" v. "legacy namespace packages". That's also now just static project metadata.)True, though, that packages should probably be:
['cinje', 'cinje.std', 'cinje.block', 'cinje.inline']