Enable retries in react-query #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yivlad
force-pushed
the
fro-650-investigate-why-refresh-didnt-work-after-coming-back-to-the
branch
from
d9925ec to
d942916
Compare
📦 Size Report
|
🖼️ Visual Regression Report for e2e🟨 Visual changes detected. Please review the report!
This report was generated by comparing 00b328d with baf1a77.Compare. |
krzkaczor
reviewed
May 28, 2024
yivlad
force-pushed
the
fro-650-investigate-why-refresh-didnt-work-after-coming-back-to-the
branch
from
4859db2 to
ad41ac7
Compare
yivlad
force-pushed
the
fro-650-investigate-why-refresh-didnt-work-after-coming-back-to-the
branch
from
ad41ac7 to
c7362bc
Compare
krzkaczor
reviewed
May 29, 2024
| @@ -7,7 +7,8 @@ export const queryClient = new QueryClient({ | |||
| queries: { | |||
| gcTime: 1_000 * 60 * 60 * 24, // 24 hours | |||
| refetchOnWindowFocus: true, | |||
| retry: 0, | |||
| retry: 3, | |||
| retryDelay: (attemptIndex) => Math.min(150 * 2 ** attemptIndex, 10_000), // reduce the base delay to 150ms | |||
There was a problem hiding this comment.
Why Math.min? it will be always below 10s with 3 retries.
There was a problem hiding this comment.
Just in case someone overrides the retry prop
oskarvu
approved these changes
May 29, 2024
krzkaczor
approved these changes
May 29, 2024
yivlad
deleted the
fro-650-investigate-why-refresh-didnt-work-after-coming-back-to-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-queryto 3createSandboxConnectorfunction.