Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme & language exports #35

Closed
Zerebokep opened this issue Sep 4, 2023 · 3 comments · Fixed by #36
Closed

theme & language exports #35

Zerebokep opened this issue Sep 4, 2023 · 3 comments · Fixed by #36
Assignees
Labels
enhancement New feature or request

Comments

@Zerebokep
Copy link

Not a bug, more of a feature request.

I would like to use next js's router.locale as language, unfortunately only auto and LangCode is accepted, it would be great if you code add string as type.

Same goes for theme, adding RenderOptions.theme as export would also work for me.

Keep up the good work.

@marsidev
Copy link
Owner

marsidev commented Sep 5, 2023

Hey, @Zerebokep!

To clarify, it would be great for you if I change the language type to:

language?: 'auto' | LangCode | 'string'

Also, export the following types: LangCode and Theme

@marsidev marsidev added the enhancement New feature or request label Sep 5, 2023
@Zerebokep
Copy link
Author

exactly :)

language?: 'auto' | LangCode | string to be precise

@Zerebokep
Copy link
Author

Works splendidly now, thank you @marsidev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants