Include all postmeta data under post['postmeta'] #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup and features
|
Hi @Cabalist and thanks for the PR! Will review this and try to get back in a day or two. To be continued. |
|
Awesome! Thanks! It evolved a little past the original PR with all the typing and some the python versions. We've been using it successfully in that time. 😄 |
|
Hi, could you please merge this PR? |
|
Nice PR. I just posted a super abbreviated version that mirrors one of your changes and felt obligied to point out that PRs should be as small as possible and not combine multiple features when possible. That said @marteinn, worth taking a look. Or at mine :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
Thanks for this project! I've been using this a lot to pull data out of wordpress exports. I noticed however that the majority of the post meta info was being thrown away. I added it in (and moved an import statement).
I've got some other fixes/improvements I'd like to PR if you are open to them. I really appreciate your work on this. :)