Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limesurvey upgrades #100

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore: limesurvey upgrades #100

merged 2 commits into from
Sep 13, 2024

Conversation

Karitham
Copy link
Contributor

@Karitham Karitham commented Jul 15, 2024

  • make 6-apache the default tag (I've read the release notes and apart from themes there should be no breaking changes)

I will be running my own branch in production for the time being, but am hopeful we can figure out a way to merge this and keep this repository a central place for limesurvey.

@Karitham Karitham force-pushed the master branch 3 times, most recently from b720461 to 74c6df5 Compare July 15, 2024 13:30
@martialblog
Copy link
Owner

Hi, thanks for the PR. Could you update the tests also? Probably just updating the input values for the image name should do it.

@Karitham
Copy link
Contributor Author

Karitham commented Jul 16, 2024

First commit (60ddf3d) fixes unit-test failures specific to the runner failures, second commit (e392813) fixes the rest that also fail for me locally (using latest helm-unittest). Hopefully the tests pass but if they don't I can revert last commit and fix all the failing tests and upgrade the action in a later PR.

@Karitham
Copy link
Contributor Author

Apparently this new syntax broke it, so I reverted the commit. Once this is ok I'll make another PR to upgrade helm-unittest

@Karitham
Copy link
Contributor Author

@Karitham
Copy link
Contributor Author

rewrote the PR to make it simpler to read and review. Just bumping ls to 6.x

limesurvey/README.md Outdated Show resolved Hide resolved
Co-authored-by: Markus Opolka <markus@martialblog.de>
@martialblog martialblog merged commit d754f31 into martialblog:master Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants