-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU message format for translations #2045
Conversation
Could you please explain further what ICU does? Thanks! |
Here in description of library that I used (see |
One more note - Tolgee already handles ICU format: it has highlighting and it shows readable result when translation is saved |
Makes sense. I will test the PR and let you know. The translation files don't need to be modified? |
No, we can just use new functions when translating the lines in Tolgee, old ones will work as before. But there can be one issue - if you support all the old versions and they can fetch new translation lines, if they will use ICU - old versions of WingetUI would not handle them properly, not sure what is the best way to resolve this. |
Hello @flatron4eg, I have been doing testing and I am afraid this PR would break older versions of WingetUI. Therefore, I can't merge it. |
@marticliment But since you already changed path to language files with UniGet rebranding (https://github.com/marticliment/WingetUI/blob/527a35a77bd0f86dc820dd33acd09c8dea55a00a/src/UniGetUI/Core/Data/LanguageData.cs#L101), older versions will not get any updates from github, cause there are no files on that old path. IMO this is the best moment to make this change. |
That is true, I did not think about that... |
Resolved all the conflicts, is there anything else have to be done before merge? |
No, everything should be fine. I will review changes and merge it as soon as I have a moment to do some testing |
Before merging this PR I will merge #2161. Then I will fix the conflicts and do the merge |
I know you are busy so I resolved the conflicts and fixed codacy issues. There is one failing test but it seems unrelated |
Thanks❤️ I will check the tests and merge |
Added support for MessageFormat from ICU for all the translation lines.