Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional description to package manager toggles #2107

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

turw41th
Copy link
Contributor

@turw41th turw41th commented Apr 8, 2024

Adds additional descriptive text to settings page according to request #2103.

  • I have read the contributing guidelines and I agree with the Code of Conduct
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the time of the contributors, who have to spend their free time reviewing, fixing and testing code that does not even compile, breaks other features or does not introduce any useful changes. Thank you for your understanding

From what I have understood, it is not necessary to specifically link the text to some property in order to be properly translatable. If this is indeed needed, please let me know.

Relates to #2103

@turw41th turw41th changed the title resolves #2103: Adds additional description to package manager toggles Adds additional description to package manager toggles Apr 8, 2024
@marticliment
Copy link
Owner

Yes, in the translation part you are correct.

Can you please share a screenshot of how the changes are shown?

@turw41th
Copy link
Contributor Author

turw41th commented Apr 8, 2024

image

It will look like this. I was experimenting with different font sizes and thought this to look best,

@marticliment
Copy link
Owner

I have two propositions:

  • What about setting its opacity to 50~80%? It will show kinda greyed out, which is the style to follow on informational texts such as this one.
  • Wouldn't it be better to remove the abbreviation (you'll -> you will)? IMO it would look more formal to not have the contraction, what do you think?

@turw41th
Copy link
Contributor Author

turw41th commented Apr 9, 2024

  • Alright I'll play with the opacity a little bit and see what looks best, I'll share another screenshot and push the changes when I'm happy with it.
  • I'm not a native English speaker myself and I'd agree with you that such abbreviations can look informal, although I think the specific one I've used is pretty much accepted in all circumstances by now. I can change it though and then see how that looks.

@turw41th
Copy link
Contributor Author

turw41th commented Apr 9, 2024

@marticliment Changed the stuff. This is how it looks with 70% which looked best to me:

image

@marticliment marticliment merged commit c5ff189 into marticliment:main Apr 10, 2024
1 check passed
@turw41th turw41th deleted the SettingsTogglesDescription branch April 11, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants