Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move message formatter in LanguageEngine, add locale for message formatter #2326

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

flatron4eg
Copy link
Contributor

@flatron4eg flatron4eg commented Jun 19, 2024

Added value for locale parameter for MessageFormatter, as plural categories ("one", "few", "other") work differently for different locales. Also refactored LanguageEngine a bit, so now MessageFormatter is part of it.

  • I have read the contributing guidelines and I agree with the Code of Conduct
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the time of the contributors, who have to spend their free time reviewing, fixing, and testing code that does not even compile, breaks other features, or does not introduce any useful changes. Thank you for your understanding

@marticliment
Copy link
Owner

marticliment commented Jun 19, 2024

I want to check the changes carefully, but it looks good at a first glance.

I will check and merge the PR in 3/4 days

@marticliment marticliment merged commit b01ec19 into marticliment:main Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants