Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WingetUI to UniGetUI #2353

Merged
merged 31 commits into from
Jul 3, 2024
Merged

Make WingetUI to UniGetUI #2353

merged 31 commits into from
Jul 3, 2024

Conversation

skanda890
Copy link
Contributor

@skanda890 skanda890 commented Jun 28, 2024 •
edited
Loading

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the time of the contributors, who have to spend their free time reviewing, fixing, and testing code that does not even compile, breaks other features, or does not introduce any useful changes. Thank you for your understanding.

This changes README.md and WebBasedData/screenshot-database-v2.json

marticliment
marticliment previously approved these changes Jun 28, 2024
View reviewed changes
@marticliment
Copy link
Owner

Id the PR is not ready, please convert it to draft

@marticliment
Copy link
Owner

Note: Only merge this when everything which needs to be changed like: paths from marticliment/WingetUI to marticliment/UniGetUI etc.

Please do not change this, I have already all the changes prepared on my local pc, ready to merge

@skanda890
Copy link
Contributor Author

skanda890 commented Jun 28, 2024 •
edited
Loading

Okay.

@marticliment marticliment marked this pull request as draft June 28, 2024 18:24
@marticliment
Copy link
Owner

I have changed it to draft

Excel Bot and others added 2 commits June 29, 2024 01:11
@skanda890
Copy link
Contributor Author

skanda890 commented Jun 29, 2024 •
edited
Loading

Okay.

@skanda890 skanda890 mentioned this pull request Jun 29, 2024
Merged
4 tasks
@skanda890 skanda890 changed the title Update README.md Make WingetUI to UniGetUI Jun 29, 2024
Excel Bot and others added 2 commits June 30, 2024 01:18
@skanda890 skanda890 marked this pull request as ready for review June 30, 2024 08:24
@skanda890 skanda890 marked this pull request as draft June 30, 2024 08:25
skanda890
skanda890 commented Jun 30, 2024
View reviewed changes
Copy link
Contributor Author

@skanda890 skanda890 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marticliment, How do you fix these conflicts?
image

@marticliment marticliment marked this pull request as ready for review June 30, 2024 09:18
@marticliment
Copy link
Owner

marticliment commented Jun 30, 2024 •
edited
Loading

No, I have not. I will change them once I publish 3.1.0 stable

@marticliment
Copy link
Owner

@marticliment, How do you fix these conflicts? image

Please revert the commit updating the screenshot-database file.
Do not update screenshot-database file manually on a branch, since then it causes conflicts to appear

@skanda890
Copy link
Contributor Author

@marticliment, How do you fix these conflicts? image

Please revert the commit updating the screenshot-database file. Do not update screenshot-database file manually on a branch, since then it causes conflicts to appear

I reverted it but still there.

@marticliment marticliment marked this pull request as draft June 30, 2024 19:22
@marticliment
Copy link
Owner

I will undraft when I have migrated all .MD files to UniGetUI

@skanda890
Copy link
Contributor Author

skanda890 commented Jul 1, 2024 •
edited
Loading

Okay

@skanda890 skanda890 marked this pull request as ready for review July 1, 2024 10:13
@skanda890 skanda890 marked this pull request as draft July 1, 2024 10:13
@skanda890
Copy link
Contributor Author

Have you updated all the paths?

@marticliment
Copy link
Owner

Which paths?

skanda890
skanda890 commented Jul 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@marticliment marticliment marked this pull request as ready for review July 3, 2024 09:23
@marticliment marticliment merged commit c88590c into marticliment:main Jul 3, 2024
1 check passed
@skanda890 skanda890 mentioned this pull request Jul 3, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marticliment marticliment marticliment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanda890 @marticliment