Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csproj duplicates and warnings #3056

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Dec 9, 2024

Fix some of csproj duplicated entries.
Fix some of warnings

marticliment
marticliment previously approved these changes Dec 10, 2024
@marticliment
Copy link
Owner

Aside from passigng the tests, have you tested that UniGetUI still works?

@marticliment
Copy link
Owner

Edit, it is not passing tests

@Saibamen
Copy link
Contributor Author

Aside from passigng the tests, have you tested that UniGetUI still works?

No, because I'm still having build error in my Visual Studio:
image

This is why I added #3057

What should I install in my VS?

@marticliment
Copy link
Owner

You need to install the Windows App Sdk version 10.0.26100.0 or 10.0.19041.0 (i am sorry, I can't recall which)

@Saibamen
Copy link
Contributor Author

image

10.0.26100.0 is for Win 11, 10.0.19041.0 is for Win 10.

I will install 19041. It is strange that Visual Studio can't suggest installing missing components via Visual Studio Installer (he did that for other components, for example .NET SDK)

@Saibamen
Copy link
Contributor Author

It works

image

@marticliment marticliment merged commit 6af0733 into marticliment:main Dec 13, 2024
2 checks passed
@Saibamen Saibamen deleted the fix_csproj branch December 13, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants