Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #531

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Improvements #531

merged 5 commits into from
Dec 28, 2022

Conversation

panther7
Copy link
Contributor

@panther7 panther7 commented Dec 27, 2022

ref #529

@panther7
Copy link
Contributor Author

Done, check it, if tis ok for you.

@marticliment

@panther7 panther7 changed the title Draft: Improvements Improvements Dec 27, 2022
@panther7
Copy link
Contributor Author

2022-12-27 21 29 27

@ppvnf
Copy link
Contributor

ppvnf commented Dec 27, 2022

Would it be possible to do this automatically to all translators (or at least the ones that have a Github account)?

@panther7
Copy link
Contributor Author

@marticliment Please try this fix f20cb99 for ISS.

@panther7
Copy link
Contributor Author

panther7 commented Dec 27, 2022

@ppvnf I can't check, if "name" is github accout. You can add "@" prefix for your name/nick and link will be created.

//edit: i added "automake" link, if you in contributors list

@panther7 panther7 force-pushed the improvements branch 2 times, most recently from 510a927 to b6854eb Compare December 27, 2022 21:17
@marticliment
Copy link
Owner

@marticliment Please try this fix f20cb99 for ISS.

It seems to work for me. Thank you!

P.D. I can merge that, right?

@panther7
Copy link
Contributor Author

Yes, u can

@ppvnf
Copy link
Contributor

ppvnf commented Dec 28, 2022

I've tested it and it works great. Thanks! Is there a simple way using Tolgee for @marticliment to add the other translators as contributors so they also have their Github profiles linked? Also, should I manually link my profile in the readme?

@panther7
Copy link
Contributor Author

Links from translators is not secured, I think, this is good solution ;-)

@marticliment
Copy link
Owner

marticliment commented Dec 28, 2022

I've tested it and it works great. Thanks! Is there a simple way using Tolgee for @marticliment to add the other translators as contributors so they also have their Github profiles linked? Also, should I manually link my profile in the readme?

Every contributor will need to add their username instead of their name

I'll add the ability to show also links in the readme (id you were to link that manually, it would get erased after the readme was generated again) This was already done by @panther7, i don¡t know where I looked that i couldn't find it, but now I see whet you did.
Great job!

@marticliment marticliment merged commit 7be860b into marticliment:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants