Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChordProParser: unspaced chords will cause issues #252

Closed
Glidias opened this issue Feb 20, 2021 · 1 comment
Closed

ChordProParser: unspaced chords will cause issues #252

Glidias opened this issue Feb 20, 2021 · 1 comment

Comments

@Glidias
Copy link

Glidias commented Feb 20, 2021

[Fsus4][F]

Also, unclosed square brackets will cause issues but i think that is fine.

[Fsus4] [F] , cleanup add space in between is okay.

Is this much of an issue?
martijnversluis added a commit that referenced this issue Feb 24, 2021
@martijnversluis
Allow chords without spacing in between
473219b 
Eg.:

    [F#][C]

is a valid Chordpro sheet

Resolves #252
@martijnversluis
Copy link
Owner

Hey @Glidias ! Thanks for reporting this issue 👍

I just published version 4.1.0 which fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Glidias @martijnversluis