Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up plugin descriptor dependencies #3

Open
wants to merge 1 commit into
base: move_composite_to_module
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@
import org.elasticsearch.aggregations.bucket.histogram.InternalAutoDateHistogram;
import org.elasticsearch.aggregations.pipeline.MovFnPipelineAggregationBuilder;
import org.elasticsearch.aggregations.pipeline.MovingFunctionScript;
import org.elasticsearch.plugins.ExtensiblePlugin;
import org.elasticsearch.plugins.Plugin;
import org.elasticsearch.plugins.ScriptPlugin;
import org.elasticsearch.plugins.SearchPlugin;
import org.elasticsearch.script.ScriptContext;

import java.util.List;

public class AggregationsPlugin extends Plugin implements SearchPlugin, ScriptPlugin {
public class AggregationsPlugin extends Plugin implements ExtensiblePlugin, SearchPlugin, ScriptPlugin {
@Override
public List<AggregationSpec> getAggregations() {
return List.of(
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugin/autoscaling/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ esplugin {
archivesBaseName = 'x-pack-autoscaling'

dependencies {
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
testImplementation(testArtifact(project(xpackModule('core'))))
testImplementation project(':modules:data-streams')
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ esplugin {
classname 'org.elasticsearch.xpack.core.XPackPlugin'
hasNativeController false
requiresKeystore false
extendedPlugins = ['aggregations']
}

tasks.named("dependencyLicenses").configure {
Expand All @@ -28,7 +29,7 @@ tasks.named("dependencyLicenses").configure {

dependencies {
compileOnly project(":server")
api project(":modules:aggregations")
compileOnly project(":modules:aggregations")
api project(':libs:elasticsearch-grok')
api project(":libs:elasticsearch-ssl-config")
api "org.apache.httpcomponents:httpclient:${versions.httpclient}"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/eql/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ esplugin {
name 'x-pack-eql'
description 'The Elasticsearch plugin that powers EQL for Elasticsearch'
classname 'org.elasticsearch.xpack.eql.plugin.EqlPlugin'
extendedPlugins = ['x-pack-ql', 'lang-painless']
extendedPlugins = ['x-pack-ql']
}

ext {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/mapper-constant-keyword/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ esplugin {
name 'constant-keyword'
description 'Module for the constant-keyword field type, which is a specialization of keyword for the case when all documents have the same value.'
classname 'org.elasticsearch.xpack.constantkeyword.ConstantKeywordMapperPlugin'
extendedPlugins = ['x-pack-core', 'lang-painless']
extendedPlugins = ['x-pack-core']
}
archivesBaseName = 'x-pack-constant-keyword'

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/mapper-unsigned-long/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ esplugin {
name 'unsigned-long'
description 'Module for the unsigned long field type'
classname 'org.elasticsearch.xpack.unsignedlong.UnsignedLongMapperPlugin'
extendedPlugins = ['x-pack-core', 'lang-painless']
extendedPlugins = ['x-pack-core']
}
archivesBaseName = 'x-pack-unsigned-long'

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/mapper-version/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ esplugin {
name 'mapper-version'
description 'A plugin for a field type to store software versions'
classname 'org.elasticsearch.xpack.versionfield.VersionFieldPlugin'
extendedPlugins = ['x-pack-core', 'lang-painless']
extendedPlugins = ['x-pack-core']
}
archivesBaseName = 'x-pack-mapper-version'

Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/ml/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ esplugin {
description 'Elasticsearch Expanded Pack Plugin - Machine Learning'
classname 'org.elasticsearch.xpack.ml.MachineLearning'
hasNativeController true
extendedPlugins = ['x-pack-autoscaling', 'lang-painless']
extendedPlugins = ['x-pack-autoscaling']
}

def localRepo = providers.systemProperty('build.ml_cpp.repo').orNull
Expand Down Expand Up @@ -70,6 +70,7 @@ esplugin.bundleSpec.exclude 'platform/licenses/**'

dependencies {
compileOnly project(':modules:lang-painless:spi')
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
compileOnly project(path: xpackModule('autoscaling'))
testImplementation(testArtifact(project(xpackModule('core'))))
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugin/ql/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ archivesBaseName = 'x-pack-ql'
dependencies {
api "org.antlr:antlr4-runtime:${antlrVersion}"
api project(path: xpackModule('mapper-version'))
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
testApi(project(xpackModule('ql:test-fixtures'))) {
exclude group: 'org.elasticsearch.plugin', module: 'ql'
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugin/rollup/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ esplugin {
archivesBaseName = 'x-pack-rollup'

dependencies {
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
compileOnly project(':modules:data-streams')
compileOnly project(path: xpackModule('ilm'))
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/spatial/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ esplugin {
name 'spatial'
description 'A plugin for Basic Spatial features'
classname 'org.elasticsearch.xpack.spatial.SpatialPlugin'
extendedPlugins = ['x-pack-core', 'legacy-geo', 'lang-painless']
extendedPlugins = ['x-pack-core', 'legacy-geo']
}

dependencies {
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/sql/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ esplugin {
name 'x-pack-sql'
description 'The Elasticsearch plugin that powers SQL for Elasticsearch'
classname 'org.elasticsearch.xpack.sql.plugin.SqlPlugin'
extendedPlugins = ['x-pack-ql', 'lang-painless']
extendedPlugins = ['x-pack-ql']
}

ext {
Expand All @@ -29,6 +29,7 @@ configurations {
archivesBaseName = 'x-pack-sql'

dependencies {
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
compileOnly(project(':modules:lang-painless:spi'))
api project('sql-action')
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugin/transform/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ esplugin {

dependencies {
compileOnly project(":server")
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))

testImplementation(testArtifact(project(xpackModule('core'))))
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/watcher/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ esplugin {
classname 'org.elasticsearch.xpack.watcher.Watcher'
hasNativeController false
requiresKeystore false
extendedPlugins = ['x-pack-core', 'lang-painless']
extendedPlugins = ['x-pack-core']
}

archivesBaseName = 'x-pack-watcher'
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/wildcard/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ esplugin {
name 'wildcard'
description 'A plugin for a keyword field type with efficient wildcard search'
classname 'org.elasticsearch.xpack.wildcard.Wildcard'
extendedPlugins = ['x-pack-core', 'lang-painless']
extendedPlugins = ['x-pack-core']
}
archivesBaseName = 'x-pack-wildcard'

dependencies {
compileOnly project(':modules:lang-painless:spi')
compileOnly project(':modules:aggregations')
compileOnly project(path: xpackModule('core'))
testImplementation(testArtifact(project(xpackModule('core'))))
}
Expand Down