-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic rtl #997
Basic rtl #997
Conversation
It seems that the PR contains a separate version of the compiled bootstrap for RTL languages. Is that observation correct? |
@reckart yes, bootstrap should be updated before merge (webjar release is not available her) |
By updated you mean removed? Why are would separate fully compiled Bootstrap CSS files for RTL and non-RTL be required? Looking at the Bootstrap documentation, the main change towards RTL support in BS5 was to replace the |
Ah, ok... now I see. The included https://getbootstrap.com/docs/5.3/getting-started/contents/#css-files |
@reckart was just about to paste same link :)) |
@solomax Actually, The BS 5.3.1 webjar is available on Maven Central: https://search.maven.org/artifact/org.webjars.npm/bootstrap/5.3.1/jar Unzipping the file, I can also see the RTL variations of the CSS files in there. |
Thanks! https://mvnrepository.com/artifact/org.webjars/bootstrap displays outdated info :( |
Maven coordinates are wrong :( we are using I've created an issue: webjars/bootstrap#184 |
Any reason not to use the According to https://www.webjars.org, the |
Also, if a new version of an |
These jars have different structure Anyway this question is for another PR :))) |
Thank you, @solomax ! |
@martin-g could you please cherry-pick this one to wicket-10 branch? :) |
Done! |
@martin-g for whatever reason I don't see this commit here: https://github.com/l0rdn1kk0n/wicket-bootstrap/commits/wicket-10.x-bootstrap-5.x :((( |
* RTL for vanilla bootstrap is added * RTL support for bootswatch was added (cherry picked from commit c1fe914)
It was my fault. Just pushed it. |
Thanks! :))) |
No description provided.