Basic rtl

[solomax]

No description provided.

[reckart]

It seems that the PR contains a separate version of the compiled bootstrap for RTL languages. Is that observation correct?

[solomax]

@reckart yes, bootstrap should be updated before merge (webjar release is not available her)

[reckart]

By updated you mean removed? Why are would separate fully compiled Bootstrap CSS files for RTL and non-RTL be required? Looking at the Bootstrap documentation, the main change towards RTL support in BS5 was to replace the XXX-left/XXX-right classes with XXX-start and XXX-end(e.g. ml-1 -> ms-1). I don't see indications that vanilla BS has any type of build-time switch for RTL-related properties.

[reckart]

Ah, ok... now I see. The included bootstrap.rtl.css is actually part of the upstream distro. I wasn't aware of that:

https://getbootstrap.com/docs/5.3/getting-started/contents/#css-files

[solomax]

@reckart was just about to paste same link :))

[reckart]

@solomax Actually, The BS 5.3.1 webjar is available on Maven Central: https://search.maven.org/artifact/org.webjars.npm/bootstrap/5.3.1/jar

Unzipping the file, I can also see the RTL variations of the CSS files in there.

[solomax]

Thanks!
I'll update this pr with new bootstrap a bit later tonight :)

https://mvnrepository.com/artifact/org.webjars/bootstrap displays outdated info :(

[solomax]

Maven coordinates are wrong :(

we are using org.webjars:bootstrap while at your link the artifact is org.webjars.npm:bootstrap

I've created an issue: webjars/bootstrap#184

[reckart]

Any reason not to use the org.webjars.npm version?

According to https://www.webjars.org, the org.webjars.npm version mirrors the contents of the respective NPM package whereas org.webjars must be manually built and deployed - seems unnecessary overhead?

[reckart]

Also, if a new version of an org.webjars.npm package is required, it appears this can be done directly from the webjars website using the Add webjar... button, just by entering the package name and selecting the version desired.

[solomax]

Any reason not to use the org.webjars.npm version?

These jars have different structure
Maybe resource load will miss in case org.webjars.npm:bootstrap will be used

Anyway this question is for another PR :)))

[martin-g]

Thank you, @solomax !

[solomax]

@martin-g could you please cherry-pick this one to wicket-10 branch? :)

[martin-g]

Done!

[solomax]

@martin-g for whatever reason I don't see this commit here: https://github.com/l0rdn1kk0n/wicket-bootstrap/commits/wicket-10.x-bootstrap-5.x :(((

[martin-g]

It was my fault. Just pushed it.

[solomax]

Thanks! :)))