-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail color doesn't update #17
Comments
Are you returning |
It's returning true always. |
I pasted your XML into the demo app and everything works correctly for me. If you want a proper fix, I'll need more information and/or code. (Or even better, a pull request :-) |
I have the same exact issue. <com.rarepebble.colorpicker.ColorPreference
android:icon="@drawable/ic_format_color_fill_white_24dp"
android:key="racer.accent"
android:title="Accent Color"
android:summary="Set the Watchface accent color."
app:colorpicker_defaultColor="#f00"/> With or without a Category the Thumbnail does not update but I can confirm that the preference is changed. |
Can you confirm that you're using the latest version of the library (1.6.0)? Also, what Android version(s) do you see it on? Does it happen on the emulator? |
Yes I am using the latest version on android 5.1.1 and 6.0
|
Hmm. Working for me on 5.1.1 emulator (and all my other devices). Are you building the library locally or using the jcenter version? What are your target version and min sdk version? Any other relevant setup you can think of? Maybe you could debug the library locally and put a breakpoint in ColorPreference.showColor() and see what's going on. |
I am using jcenter but I was considering to fork git and debug it.
|
Well, I'm out of ideas here. If you could investigate with a debugger, that would be helpful. |
I'll give it a shot and try to understand why it does not update the
|
We're using a couple of ColorPreference in a PreferenceFragment, the XMLfor the fragment is as follows;
When changing the text_color preference, the onPreferenceChange listener is fired, however, the thumbnail does not update, regardless of whether setColor() is called or not on the changing preference within the listener.
When changing the background_color preference, the thumbnail updates correctly.
The text was updated successfully, but these errors were encountered: