Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model gdep015OC1.h does not work - new model gdeh0154d67 #31

Closed
DominicD opened this issue Feb 7, 2021 · 22 comments · Fixed by #32
Closed

Model gdep015OC1.h does not work - new model gdeh0154d67 #31

DominicD opened this issue Feb 7, 2021 · 22 comments · Fixed by #32
Assignees
Labels
New epaper New Epd implementation

Comments

@DominicD
Copy link
Contributor

DominicD commented Feb 7, 2021

Hi I have now bought this mode l from Waveshare.
I try to get the demos/demo-epaper.cpp running, however it does not display anything.
I have checked all the oins and the sdkconfig and they should be correct.

Do you have any tips on what I am doing wrong?

@DominicD
Copy link
Contributor Author

DominicD commented Feb 7, 2021

I think I found the problem. Seems there is a new Version from waveshare which uses different Display.
I tried with GxEPD2 and the model GDEH0154D67 works.

@DominicD
Copy link
Contributor Author

DominicD commented Feb 7, 2021

Maybe you can tell me how you went about implementing it. E.g. where you got the lut and commands and other information from. I will try to integrate it

@martinberlin martinberlin self-assigned this Feb 7, 2021
@martinberlin
Copy link
Owner

Ah ok I didn't know that. Can you send me the link to the GDEH0154D67 class in GxEPD2?
I based this project in GxEPD luts / initialization commands and the Waveshare / Goodisplay demos itself. So sure if you want just copy existing model and try to make the necessary modifications.

Basically it's initialization commands and the right command before sending the pixel buffer + refresh. Just tell me if you need help.

@DominicD
Copy link
Contributor Author

DominicD commented Feb 7, 2021

If I make a pull request should it be against this repor or https://github.com/martinberlin/CalEPD?

@martinberlin
Copy link
Owner

Against this one is ok! Then I test and review updates, like once a month, I make a new CalEPD release.
So the things are developed and tested here, then I export the updates to the independent components. No idea if it's the best methodology but it worked so far. Thanks a lot for your collaboration

@martinberlin martinberlin added the New epaper New Epd implementation label Feb 8, 2021
@martinberlin
Copy link
Owner

Can you upload here a photo of this epaper so I add it also in the Wiki?
I will review your pull request and merge it today. Thanks!

@martinberlin martinberlin changed the title Model gdep015OC1.h does not work Model gdep015OC1.h does not work - new model gdeh0154d67 Feb 9, 2021
@DominicD
Copy link
Contributor Author

DominicD commented Feb 9, 2021

Sure. I tried the demo-epaper.cpp and the demo-sleep-clock.cpp. Have not tried yet partial update.
I will post pictures as soon as I can

@martinberlin
Copy link
Owner

No problem. Great that it works, I will merge it in master, and then clean up some deprecated methods.

@martinberlin
Copy link
Owner

Leaving this open @DominicD so you can upload a picture in the ticket whenever you find some time. Thanks a lof for your contribution

@martinberlin martinberlin reopened this Feb 9, 2021
martinberlin added a commit that referenced this issue Feb 9, 2021
@DominicD
Copy link
Contributor Author

DominicD commented Feb 9, 2021

IMG_20210209_195836.jpg

Partial refresh seems to be buggy:
IMG_20210209_195929.jpg

@martinberlin
Copy link
Owner

martinberlin commented Feb 9, 2021

Ups partial refresh needs a fix right?
Thanks for the pictures, can you try partial refresh with gxEPD2 and see if it works?

if it does I will compare the two classes and see if I can find something.

@DominicD
Copy link
Contributor Author

DominicD commented Feb 10, 2021

GIF_20210210_074005.gif

Partial update works fine with GxEPD2
Maybe this comment helps:

  // setPartialWindow, use parameters according to actual rotation.
  // x and w should be multiple of 8, for rotation 0 or 2,
  // y and h should be multiple of 8, for rotation 1 or 3,
  // else window is increased as needed,
  // this is an addressing limitation of the e-paper controllers

@martinberlin
Copy link
Owner

Thanks for the update. Tried to implement it but I cannot test:

[refactor/oop bf2caa1] #31 Implement partial update the gxepd2 way. Just call updateWindow(x,y,width,height)

Just checkout refactor/oop and try to run first demo-epaper full test. And then add somewhere an updateWindow(x,y,w,h) and try partial.

@DominicD
Copy link
Contributor Author

It is still buggy

@DominicD
Copy link
Contributor Author

DominicD commented Feb 10, 2021

If you want we could test it together to find out what the problem is.
Maybe we can find a time to have a call with screensharing or something

@martinberlin
Copy link
Owner

Sure this Friday or in the weekend I‘ve time. But buggy in the same way as before?
Does full update still work?
I tried to repeat same commands as gxEPD2 but is hard to get it the first time without having the Epaper. But for sure let’s find some time and do some screen sharing. I will check anyways and see if I didn’t missed anything.

@DominicD
Copy link
Contributor Author

The full update still works.
In your wiki you mention that the old model gdep015OC1.h is also buggy with partial refresh do you still have that one? Maybe it helps you if you fix that one.

Sure we can try to work on it together. Do you have discord or anything else? Maybe you can share your contact details via E-Mail?

@martinberlin
Copy link
Owner

Sure you can email me at Martin at luckycloud.de
I also use discord but I don’t remember my user at the moment. Let’s compare together if I’m missing something, following gxEPD2 way. There must be something that is different!

martinberlin added a commit that referenced this issue Feb 14, 2021
@martinberlin
Copy link
Owner

Great find @DominicD
Now partial update works as expected (No more white points) it seems it was the power on mode that you found. Thanks.
Now I will cleanup and try to optimize SPI

@martinberlin
Copy link
Owner

Nice teamwork, will wait till the end of next week before closing, feel free to suggest any optimization if you feel like @DominicD
Full update working, partial refresh working. Wiki entry: https://github.com/martinberlin/cale-idf/wiki/Model-gdeh0154d67.h

@martinberlin
Copy link
Owner

New epaper watch in the making with partial refresh
IMG_20210216_110818_8522

@martinberlin
Copy link
Owner

Closing down here. @DominicD thanks for your collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New epaper New Epd implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants