Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code analysis hack #2630

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove code analysis hack #2630

merged 1 commit into from
Jul 23, 2024

Conversation

martincostello
Copy link
Owner

Try and repro dotnet/roslyn#70368 again.

Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (c09b359) to head (9110543).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   77.31%   77.31%           
=======================================
  Files         128      128           
  Lines        2566     2566           
  Branches      391      391           
=======================================
  Hits         1984     1984           
  Misses        401      401           
  Partials      181      181           
Flag Coverage Δ
linux 77.31% <ø> (ø)
macos 77.31% <ø> (ø)
windows 77.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review July 23, 2024 15:05
@martincostello martincostello merged commit a935bf6 into main Jul 23, 2024
15 checks passed
@martincostello martincostello deleted the remove-codeql-hack branch July 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants