Skip to content

Conversation

@martincostello
Copy link
Owner

  • Only generate on Windows.
  • Rename file.

- Only generate on Windows.
- Rename file.
Copilot AI review requested due to automatic review settings June 18, 2025 08:01
@martincostello martincostello enabled auto-merge (rebase) June 18, 2025 08:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SBOM generation process by restricting it to run only on Windows and renaming the generated SBOM file.

  • Only generates SBOM on Windows runners
  • Renames the generated artifact and output file for clarity
Comments suppressed due to low confidence (2)

.github/workflows/build.yml:87

  • The new artifact name 'xunit-logging.spdx.json' may be misleading if the file content remains an SBOM. Consider using a name that more clearly reflects its purpose.
        artifact-name: xunit-logging.spdx.json

.github/workflows/build.yml:88

  • Ensure that the new output file name accurately reflects its content. If the file is an SBOM, a name such as 'sbom.spdx.json' might be more intuitive.
        output-file: ./artifacts/xunit-logging.spdx.json

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (3666116) to head (4fcecd0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          16       16           
  Lines         284      284           
  Branches       37       37           
=======================================
  Hits          280      280           
  Misses          2        2           
  Partials        2        2           
Flag Coverage Δ
linux 98.59% <ø> (ø)
macos 97.88% <ø> (-0.71%) ⬇️
windows 98.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants