Skip to content

Conversation

@martincostello
Copy link
Owner

Move CA1873 suppression to the right place.

Move CA1873 suppression to the right place.
Copilot AI review requested due to automatic review settings July 15, 2025 18:11
@martincostello martincostello added the bug Something isn't working label Jul 15, 2025
@martincostello martincostello enabled auto-merge (rebase) July 15, 2025 18:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Move CA1873 suppression to the appropriate test project files and remove it from the main SampleApp project.

  • Removed CA1873 from NoWarn in the main SampleApp project.
  • Added CA1873 suppression in the two XUnit test project files.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/SampleApp/SampleApp.csproj Removed CA1873 from the <NoWarn> list
tests/Logging.XUnit.v3.Tests/MartinCostello.Logging.XUnit.v3.Tests.csproj Added <NoWarn>$(NoWarn);CA1873</NoWarn>
tests/Logging.XUnit.Tests/MartinCostello.Logging.XUnit.Tests.csproj Added <NoWarn>$(NoWarn);CA1873</NoWarn>

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (0529d22) to head (ae13881).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          16       16           
  Lines         284      284           
  Branches       37       37           
=======================================
  Hits          280      280           
  Misses          2        2           
  Partials        2        2           
Flag Coverage Δ
linux 98.59% <ø> (ø)
macos 97.88% <ø> (-0.71%) ⬇️
windows 98.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 432b33e into main Jul 15, 2025
14 checks passed
@martincostello martincostello deleted the disable-ca1873-2 branch July 15, 2025 18:13
This was referenced Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants