-
-
Notifications
You must be signed in to change notification settings - Fork 14
Move CA1873 suppression #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Move CA1873 suppression to the right place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Move CA1873 suppression to the appropriate test project files and remove it from the main SampleApp project.
- Removed CA1873 from
NoWarnin the main SampleApp project. - Added CA1873 suppression in the two XUnit test project files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/SampleApp/SampleApp.csproj | Removed CA1873 from the <NoWarn> list |
| tests/Logging.XUnit.v3.Tests/MartinCostello.Logging.XUnit.v3.Tests.csproj | Added <NoWarn>$(NoWarn);CA1873</NoWarn> |
| tests/Logging.XUnit.Tests/MartinCostello.Logging.XUnit.Tests.csproj | Added <NoWarn>$(NoWarn);CA1873</NoWarn> |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 16 16
Lines 284 284
Branches 37 37
=======================================
Hits 280 280
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Move CA1873 suppression to the right place.