Skip to content

Add zizmor #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Add zizmor #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: false
show-progress: false

- name: Setup .NET SDK
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: true # zizmor: ignore[artipacked] Needed to push commits
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zizmor rule name 'artipacked' appears to be misspelled. This should be verified against the correct zizmor rule name for credential persistence warnings.

Suggested change
persist-credentials: true # zizmor: ignore[artipacked] Needed to push commits
persist-credentials: true # zizmor: ignore[persist-credentials] Needed to push commits

Copilot uses AI. Check for mistakes.
show-progress: false
token: ${{ secrets.COSTELLOBOT_TOKEN }}

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: false
show-progress: false

- name: Initialize CodeQL
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/dependency-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: false
show-progress: false

- name: Review dependencies
Expand Down
19 changes: 16 additions & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ on:
- dotnet-nightly
workflow_dispatch:

permissions:
contents: read
permissions: {}

env:
FORCE_COLOR: 3
Expand All @@ -24,27 +23,41 @@ env:
# renovate: datasource=github-releases depName=PSScriptAnalyzer packageName=PowerShell/PSScriptAnalyzer
PSSCRIPTANALYZER_VERSION: '1.24.0'
TERM: xterm
# renovate: datasource=github-releases depName=zizmor packageName=zizmorcore/zizmor
ZIZMOR_VERSION: '1.12.0'

jobs:
lint:
runs-on: ubuntu-latest

permissions:
actions: read
contents: read
security-events: write

steps:

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: false
show-progress: false

- name: Add actionlint problem matcher
run: echo "::add-matcher::.github/actionlint-matcher.json"

- name: Lint workflows
- name: Lint workflows with actionlint
uses: docker://rhysd/actionlint:1.7.7@sha256:887a259a5a534f3c4f36cb02dca341673c6089431057242cdc931e9f133147e9
with:
args: -color

- name: Lint workflows with zizmor
uses: zizmorcore/zizmor-action@5ca5fc7a4779c5263a3ffa0e1f693009994446d1 # v0.1.2
with:
persona: pedantic
version: ${{ env.ZIZMOR_VERSION }}

- name: Lint markdown
uses: DavidAnson/markdownlint-cli2-action@992badcdf24e3b8eb7e87ff9287fe931bcb00c6e # v20.0.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ossf-scorecard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- cron: '0 5 * * MON'
workflow_dispatch:

permissions: read-all
permissions: read-all # zizmor: ignore[excessive-permissions] Recommended permissions for OSSF Scorecard

jobs:
analysis:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
filter: 'tree:0'
persist-credentials: true # zizmor: ignore[artipacked] Needed to push commits
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zizmor rule name 'artipacked' appears to be misspelled. Based on the context of persisting credentials for pushing commits, this should likely be 'artipacked' corrected to 'artipacked' or the correct rule name.

Suggested change
persist-credentials: true # zizmor: ignore[artipacked] Needed to push commits
persist-credentials: true # zizmor: ignore[persist-credentials] Needed to push commits

Copilot uses AI. Check for mistakes.
show-progress: false
token: ${{ secrets.COSTELLOBOT_TOKEN }}

Expand Down
Loading