Fix Tokenize of new line, Remove space inserts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ public class InteractiveExecutor : StatefulExecutorBase | |||
| /// <param name="context"></param> | |||
| public InteractiveExecutor(LLamaContext context) : base(context) | |||
| { | |||
| _llama_token_newline = Context.NativeHandle.Tokenize("\n", false, Context.Encoding); | |||
There was a problem hiding this comment.
Seems like a much better way to do it 👍
|
Looks good, thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope im not getting in the way here.
Been playing with the GUFF branch, had a few issues with the InteractiveExecutor throwing trying to tokenize
\nI changed it to use the newline for LLama.cpp, not sure if this is the correct approch, so feel free to scrutinize.
I also removed the inserted spaces as they are no longer required llama : more tokenizer fixes #2810
All 3 executors seem to be working for me now