Skip to content

Commit

Permalink
fs-coda-fix-readlink-buffer-overflow-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: need consistent spacing around '+' (ctx:VxW)
torvalds#35: FILE: fs/coda/upcall.c:356:
+		     INSIZE(readlink), OUTSIZE(readlink)+ *length);
 		                                        ^

ERROR: space prohibited after that open parenthesis '('
torvalds#45: FILE: fs/coda/upcall.c:364:
+		if ( retlen >= *length )

ERROR: space prohibited before that close parenthesis ')'
torvalds#45: FILE: fs/coda/upcall.c:364:
+		if ( retlen >= *length )

total: 3 errors, 0 warnings, 18 lines checked

./patches/fs-coda-fix-readlink-buffer-overflow.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Jul 29, 2015
1 parent 324796f commit cd425df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/coda/upcall.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ int venus_readlink(struct super_block *sb, struct CodaFid *fid,
error = coda_upcall(coda_vcp(sb), insize, &outsize, inp);
if (!error) {
retlen = outp->coda_readlink.count;
if ( retlen >= *length )
if (retlen >= *length)
retlen = *length - 1;
*length = retlen;
result = (char *)outp + (long)outp->coda_readlink.data;
Expand Down

0 comments on commit cd425df

Please sign in to comment.