Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering torque units for Subaru DBC signals #80

Open
martinl opened this issue Apr 22, 2022 · 9 comments
Open

Steering torque units for Subaru DBC signals #80

martinl opened this issue Apr 22, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@martinl
Copy link
Owner

martinl commented Apr 22, 2022

Find ratios for following signals (Nm units):

  • Driver steering torque: ["Steering_Torque"]['Steer_Torque_Sensor']
  • EPS steering torque: ["Steering_Torque"]['Steer_Torque_Output']
@martinl martinl added the enhancement New feature or request label Apr 22, 2022
@martinl
Copy link
Owner Author

martinl commented Jun 2, 2023

analyzing SSM4 logs vs screen recording may provide some hints

@jnewb1
Copy link

jnewb1 commented Jun 7, 2023

SSM4, in NM. Field is called "Torque Sensor Main"
test
In cabana:
image

@jnewb1
Copy link

jnewb1 commented Jun 7, 2023

test
image

@martinl
Copy link
Owner Author

martinl commented Jun 8, 2023

Nice, can you get some numeric values so we can figure out the conversion formula for dbc

@jnewb1
Copy link

jnewb1 commented Jun 8, 2023

Nice, can you get some numeric values so we can figure out the conversion formula for dbc

Yea I’ll try and get a combined dataset with the can data and the ssm4 logs synced up

@jnewb1
Copy link

jnewb1 commented Jun 9, 2023

test

test1.csv

Here's a csv where i synced up the ssm4 data and the can data to the best of my ability. I'm not 100% sure if "Torque Sensor" in ssm4 is torque output or driver input, but it seemed to align better with our current "Torque Sensor" values in the dbc, which would give -0.012 as the factor.

@martinl
Copy link
Owner Author

martinl commented Jul 15, 2023

Thanks, I'll create opendbc and openpilot PR-s if you have not done it already

@martinl
Copy link
Owner Author

martinl commented Jul 18, 2023

Looks like EPS Steer_Torque_Output already has -10 scaling factor:

  SG_ COUNTER : 8|4@1+ (1,0) [0|15] "" XXX
  SG_ Steer_Torque_Output : 13|11@1- (-10,0) [0|255] "" XXX
  SG_ Signal1 : 24|8@1+ (1,0) [0|511] "" XXX
- SG_ Steer_Torque_Sensor : 45|11@1- (-1,0) [0|255] "" XXX
+ SG_ Steer_Torque_Sensor : 45|11@1- (-0.012,0) [0|255] "Nm" XXX
  SG_ Steering_Active : 61|1@0+ (1,0) [0|1] "" XXX
  SG_ Steering_Disabled : 63|1@1+ (1,0) [0|1] "" XXX

@martinl
Copy link
Owner Author

martinl commented Jul 18, 2023

commaai/opendbc#901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants