Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FJR #66

Merged
merged 10 commits into from
Mar 27, 2023
Merged

Conversation

DominikPeters
Copy link
Contributor

Add checks for Full Justified Representation (brute force and gurobi).

In the process, added some extra property tests (check that logical implications and contrapositives hold on instances).

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #66 (f20b12d) into master (2da4003) will increase coverage by 0.03%.
The diff coverage is 93.54%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   91.24%   91.28%   +0.03%     
==========================================
  Files          11       11              
  Lines        3141     3200      +59     
  Branches      989     1006      +17     
==========================================
+ Hits         2866     2921      +55     
- Misses        161      163       +2     
- Partials      114      116       +2     
Impacted Files Coverage Δ
abcvoting/misc.py 87.50% <50.00%> (-1.87%) ⬇️
abcvoting/properties.py 95.08% <96.55%> (+0.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da4003...f20b12d. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken

Verified

This commit was signed with the committer’s verified signature.
nbbeeken Neal Beeken
@martinlackner martinlackner merged commit 22ee80f into martinlackner:master Mar 27, 2023
@DominikPeters DominikPeters deleted the implement-fjr branch March 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants