Weighted rules & weighted properties #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be consistent with other methods of this class
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 91.13% 91.20% +0.07%
==========================================
Files 11 11
Lines 3418 3389 -29
Branches 1071 1067 -4
==========================================
- Hits 3115 3091 -24
+ Misses 176 173 -3
+ Partials 127 125 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brute-forcechecks for PJR and EJR, since those require design decisions (currently, these iterate over voter groups of specific size; with weights we would probably need to iterate over all subsets of voters or switch to iterating over subsets of candidates)NotImplementedErrorforphragmen-enestromfor weighted profile (was actually already implemented)consensus-ruleequal-shares(and its variants) to work for weighted profilesconvert_to_weighted(property truth values and rule outputs should be invariant under this operation)It's probably best to wait a few days before merging this PR to see whether anything comes up.