Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docstring about weights #69

Merged
merged 1 commit into from
May 17, 2023

Conversation

DominikPeters
Copy link
Contributor

The documentation regarding Voter.weight said:

This should not be used as the number of voters with these approved candidates.

I'm not sure what this means, so I've replace it with:

If weight is an integer, the voter is interpreted as if there are weight many voters with the same approval set.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #69 (6329cfd) into master (cbd70e7) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          11       11           
  Lines        3400     3400           
  Branches     1072     1072           
=======================================
  Hits         3120     3120           
  Misses        161      161           
  Partials      119      119           
Impacted Files Coverage Δ
abcvoting/preferences.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd70e7...6329cfd. Read the comment docs.

@martinlackner martinlackner merged commit 99e7922 into martinlackner:master May 17, 2023
@DominikPeters DominikPeters deleted the weight-docstring branch May 17, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants