Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constexpr scope guards #5

Open
Morwenn opened this issue Aug 14, 2022 · 2 comments
Open

constexpr scope guards #5

Morwenn opened this issue Aug 14, 2022 · 2 comments

Comments

@Morwenn
Copy link

Morwenn commented Aug 14, 2022

Hi, it occurred to me recently that it is easily possible to make scope guards constexpr in C++20 by making uncaught_exceptions constexpr itself. The following function should be very simple yet sufficient:

constexpr int uncaught_exceptions() noexcept
{
    if (std::is_constant_evaluated()) {
        return 0;
    } else {
        return std::uncaught_exceptions();
    }
}

At constexpr time, there shouldn't be any exception in flight at any moment since throw terminates the compilation, therefore we can safely return 0, it will always be true.

I know that basing scope guards on uncaught_exceptions() is fragile because of known issues with coroutines, but the proposed change is arguably rather useful, is a strict improvement to the existing implementation, and makes it work at compile-time, a context where it will correctly work even in the presence of coroutines.

Anyway, thanks for the library :)

@martinmoene
Copy link
Owner

Thanks @Morwenn, for your interesting observation. I'll try and incorporate it.

martinmoene added a commit that referenced this issue Aug 17, 2022
ToDo: unique_resource.

See configuration macros `scope_CONFIG_NO_EXTENSIONS` and `scope_CONFIG_NO_CONSTEXPR`.
@martinmoene
Copy link
Owner

martinmoene commented Aug 17, 2022

Todo:

  • add C++20 to GitHub Actions builds (msvc already includes c++latest).
  • make unique_resource constexpr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants