-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong C++ version check for span_HAVE_NORETURN? #83
Comments
martinmoene
added a commit
that referenced
this issue
Feb 4, 2024
Also thanks to the gsl-lite project for the compiler version information. https://github.com/gsl-lite/gsl-lite/blob/bd9eb162d42d8ae6a7e86902ca7060247d71ac41/include/gsl/gsl-lite.hpp#L744
@martinmoene Would you mind making a new release including this fix? We include your projects directly into ours and I prefer referring to a specific version/tag. |
@eepp Yeah, I'll do that, thanks for the heads-up. |
@eepp Created release 0.11.0; notes yet to be edited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiling as C++11, I see:
The definition of
span_HAVE_NORETURN
is:cppreference says it's available in C++11:
https://en.cppreference.com/w/cpp/language/attributes/noreturn
So I guess the definition of
span_HAVE_RETURN
should bespan_CPP11_OR_GREATER
or one of thespan_CPP11_*
ones. I have no idea about the support of MSVC for this, unfortunately.The text was updated successfully, but these errors were encountered: