workflows: Run unit tests in our tasks container

.github/workflows/release.yml

@@ -52,7 +52,7 @@ jobs:
     permissions: {}
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/cockpit-project/unit-tests
+      image: quay.io/cockpit/tasks:latest
       options: --user root
     steps:
       - name: Checkout website repository

.github/workflows/unit-tests.yml

@@ -4,48 +4,33 @@ jobs:
   unit-tests:
     runs-on: ubuntu-22.04
     permissions: {}
+    container:
+      image: quay.io/cockpit/tasks:latest
+      options: --user 1001
     strategy:
       matrix:
-        startarg:
-          # avoid check-memory on i386, it has literally thousands of uninteresting/wrong errors
-          - { make: 'check-memory', cc: 'gcc', tag: 'latest' }
-          # with default Python bridge
-          - { make: 'distcheck', cc: 'clang', tag: 'latest' }
-          - { make: 'distcheck', cc: 'gcc', tag: 'i386' }
-          # with old C bridge
-          - { make: 'distcheck', cc: 'gcc', distcheck_flags: '--enable-old-bridge', tag: 'latest' }
+        target:
+          - check-memory
+          - distcheck
           # this runs static code checks, unlike distcheck
-          - { make: 'check', cc: 'gcc', tag: 'latest' }
-          - { make: 'pytest-cov', cc: 'gcc', tag: 'latest' }
+          - check
+          - pytest-cov
       fail-fast: false
     timeout-minutes: 60
+    env:
+      FORCE_COLOR: 1
+      TEST_BROWSER: firefox
+      CFLAGS: '-O2'
     steps:
       - name: Clone repository
         uses: actions/checkout@v4
         with:
           # need this to also fetch tags
           fetch-depth: 0
+          submodules: true
 
-      - name: Build unit test container if it changed
-        run: |
-          changes=$(git diff --name-only origin/${{ github.event.pull_request.base.ref }}..HEAD -- containers/unit-tests/)
-          if [ -n "${changes}" ]; then
-            case '${{ matrix.startarg.tag }}' in
-              i386) arch=i386;;
-              latest) arch=amd64;;
-            esac
-            containers/unit-tests/build $arch
-          fi
-
-      - name: Run unit-tests container
+      - name: Run unit test
         timeout-minutes: 30
-        # HACK: -gdwarf-4 is for clang: https://bugs.kde.org/show_bug.cgi?id=452758
         run: |
-          containers/unit-tests/start \
-              --verbose \
-              --env=FORCE_COLOR=1 \
-              --env=CC='${{ matrix.startarg.cc }}' \
-              --env=CFLAGS='-O2 -gdwarf-4' \
-              --env=EXTRA_DISTCHECK_CONFIGURE_FLAGS='${{ matrix.startarg.distcheck_flags }}' \
-              --image-tag='${{ matrix.startarg.tag }}' \
-              --make '${{ matrix.startarg.make }}'
+            ./autogen.sh
+            make -j$(nproc) '${{ matrix.target }}'