Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon validation (flatpak) #782

Merged
merged 2 commits into from
Aug 27, 2022
Merged

Fix icon validation (flatpak) #782

merged 2 commits into from
Aug 27, 2022

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Aug 27, 2022

  • The XDG spec requires the installed app icon to be a perfect square.
  • The dimensions of the icon are 256x256 and not 512x512, so install it in the proper directory.

guihkx added 2 commits August 27, 2022 16:27
@guihkx
chore: make the RSS Guard icon match width and height
9ffa03e 
The XDG spec requires the installed app icon to be a perfect square.
@guihkx
fix: install the app icon to the 256x256 directory
60561b3 
The dimensions of the icon are not 512x512.
@guihkx guihkx mentioned this pull request Aug 27, 2022
Merged
@martinrotter martinrotter merged commit 605c1b0 into martinrotter:master Aug 27, 2022
@martinrotter martinrotter added Status-Fixed Ticket is resolved. Type-Desktop-Integration Application badly integrates into used desktop environment. labels Aug 27, 2022
@martinrotter martinrotter added this to the 4.2.4 milestone Aug 27, 2022
@martinrotter
Copy link
Owner

thx

@guihkx guihkx deleted the icon-fix branch August 27, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status-Fixed Ticket is resolved. Type-Desktop-Integration Application badly integrates into used desktop environment.
Projects
None yet
Milestone
4.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@guihkx @martinrotter