Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray #13

Closed
smaragdus opened this issue Dec 7, 2017 · 16 comments
Closed

Tray #13

smaragdus opened this issue Dec 7, 2017 · 16 comments

Comments

@smaragdus
Copy link

Suggestion
Option to minimize/close Textilosaurus to tray. 'Settings' - 'Tools' - 'User interface' - new tab - 'Tray' with two check-boxes:

  • Minimize to tray
  • Close to tray

Example
If 'Minimize to tray' is not checked but 'Close to tray' is checked Textilosaurus would minimize to task bar and close to tray.

@martinrotter
Copy link
Owner

Should tray icon be available also when ALL Textosaurus editors are closed? So that it could act as "quick launcher" too?

@smaragdus
Copy link
Author

@martinrotter

Should tray icon be available also when ALL Textosaurus editors are closed? So that it could act as "quick launcher" too?

For me after program has exited there is no need that the tray icon should continue to reside in system tray. I usually launch programs with dedicated launchers.

I suppose tray icon should have some basic commands- Show/Settings/Exit, etc.

@martinrotter
Copy link
Owner

martinrotter commented Mar 27, 2018

So you basically want tray to be able to HIDE Textosaurus main window so that is is entirely hidden (not visible in main Windows panel)?

@smaragdus
Copy link
Author

I think that on Window 'minimize to tray' is a common option- when enabled program goes to system tray on minimize (visible or invisible part), when not enabled program goes to task bar on minimize. I think your RSS Guard offers such options. On Linux it may be different though- as far as I know system tray has been completely removed from Gnome 3.

@martinrotter
Copy link
Owner

Yes, basically agree. Tray support will get added soon.

@martinrotter martinrotter modified the milestone: 0.9.1 Apr 17, 2018
martinrotter pushed a commit that referenced this issue Apr 17, 2018
martinrotter pushed a commit that referenced this issue Apr 17, 2018
@martinrotter
Copy link
Owner

martinrotter commented Apr 17, 2018

Please, test this on development build once it gets compiled. It is switchable from settings/gui.

@smaragdus
Copy link
Author

smaragdus commented Apr 18, 2018

Textosaurus version 0.9.0.0 crashes when I check Enable Tray Icon and click Apply, screen:

textosaurus 0 9 0 0 - crash - 002

This happens under Windows x64.

@martinrotter martinrotter reopened this Apr 18, 2018
@martinrotter
Copy link
Owner

Is that reproducible?

@martinrotter
Copy link
Owner

Added possible fix - 0f56dc0

Please test once it gets compiled. Also, debugging log from crash would be nice.

@smaragdus
Copy link
Author

Added possible fix - 0f56dc0

Please test once it gets compiled. Also, debugging log from crash would be nice.

I will test it. Do the Development builds generate debug logs?

I can provide dump (.dmp) files but I don't know whether these dump files would be of any use.

@martinrotter
Copy link
Owner

Yes, I fixed the build (I had compilation error there), now it will build latest commit, dmp files could probably help. You just run textosaurus like this - https://github.com/martinrotter/rssguard/wiki/Generating-debug-log-file

So, 43d5130 is now the latest commit which should be available in "Development builds" in 15 minutes.

@martinrotter
Copy link
Owner

martinrotter commented Apr 18, 2018

I managed to reproduce the issue on clean Windows 8 x64 (but suprisingly not on Windows 7 x64 neither on Windows 10 x64).

@smaragdus
Copy link
Author

Off-topic
As you mentioned RSS Guard I stopped using it some time ago because of severe problems with updating feeds. Are you willing to investigate problems I open new issue?

@martinrotter
Copy link
Owner

E-mail arrived, saying

I tested textosaurus-0.9.1-43d5130-win64 and there are no more crashes when I check Enable Tray Icon, problem seems fixed.

But I do not see the comment here, can you confirm it is fixed?

@smaragdus
Copy link
Author

It seems there was an issue with GitHub- I got duplicate comment, when I deleted one of the duplicates it seems the other also got deleted.

Yes, I will post the original comment below.

I tested textosaurus-0.9.1-43d5130-win64 and there are no more crashes when I check Enable Tray Icon, problem seems fixed.

Since there are no more crashes and textosaurus behaves as expected you may close this issue.

@smaragdus smaragdus mentioned this issue Apr 18, 2018
@martinrotter
Copy link
Owner

As you mentioned RSS Guard I stopped using it some time ago because of severe problems with updating feeds. Are you willing to investigate problems I open new issue?

Yes, open new issue, describe the situation in great detail. I will probably have to completely rewrite the feed update logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants