New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when semicolon present in attachment name #219

Merged

martinrusev merged 1 commit into martinrusev:master from nicknytko:master

Apr 22, 2022

Contributor

nicknytko commented Apr 4, 2022 •

edited

Loading

Fixes crash when ; present in attachment name.

Example content disposition, slightly edited for privacy:

attachment; filename="abcd;efgh;b.jpg";
	size=54924; creation-date="Thu, 10 Mar 2022 20:38:32 GMT";
	modification-date="Thu, 10 Mar 2022 20:38:28 GMT"

This patch splits the content disposition on semicolons, ignoring when it is present inside of a "-delimited string. Should resolve #220


          Fix crash when semicolon in attachment name

7c8098e

sebix commented Apr 5, 2022

Reminds me of c-like for-loop coding. When it works, it's still better than a bug :)

What would be cool are test cases, so that future changes or re-factoring don't break the compatibility again.

martinrusev merged commit 73ef226 into martinrusev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet