Mas i370 deletepending #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if there was ongoing work (i.e. the clerk had control over the manifest), the penciller could not confirm deletions. Now it may confirm, and defer the required manifest update to a later date (prompted by another delete confirmation request).
Rather than waiting on next delete confirmation request
Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
…ner/leveled into mas-i370-deletepending
martinsumner
added a commit
that referenced
this pull request
May 24, 2022
* All confirmed deletions to complete when manifest is not lockable Previously if there was ongoing work (i.e. the clerk had control over the manifest), the penciller could not confirm deletions. Now it may confirm, and defer the required manifest update to a later date (prompted by another delete confirmation request). * Refactor to update manifest even without on return of manifest Rather than waiting on next delete confirmation request * Update src/leveled_pmanifest.erl Co-authored-by: Thomas Arts <thomas.arts@quviq.com> * Missing commit Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistake made when pushing #377 as there was an outstanding response to review feedback that had been uncommitted