Now supports drafts authored using outline.el (i.e. draft-*.org) #2
Conversation
| $(error Read README.md for setup instructions) | ||
| endif | ||
|
|
||
| draft_type := $(suffix $(firstword $(wildcard $(draft).md $(draft).xml))) | ||
| draft_type := $(suffix $(firstword $(wildcard $(draft).md $(draft).xml) $(draft).org )) |
There was a problem hiding this comment.
Since the standard make invocation will create a .xml file from the .org, you need to put the .org ahead of the .xml file in this list. The consequences aren't that dire, but better to be correct.
There was a problem hiding this comment.
Oooh, good catch, it should be changed. So help me here, do I make the change on my fork and then make another pull request?
There was a problem hiding this comment.
Add another commit and push that. The PR tracks the tip of the branch, so I'll see any changes you make to the branch.
|
Looks good. Is there anything that you would need to install in order to get outline2xml installed for a travis build? Or is this something that you would prefer not to do (too hard, perhaps). |
|
outline2xml is a script that was written and maintain by a few of us in the NETCONF WG. It is not something that to generally accessible (e.g., posted in GH). Would it make sense to put it in i-d-template/lib/ or maybe i-d-template/bin/? Separately, I noticed that the Makefile has: But this pull request doesn't put anything into README.md regarding .org files. Should we leave it undocumented since outline2xml isn't generally available? |
|
Undocumented is OK for now. Add the script to lib if you like. Does it have any dependencies that might be hard to find? |
Added links for tools called by Makefile. Added outline as an input format.
Now supports drafts authored using outline.el (i.e. draft-*.org)
|
I have to apologize, I completely left this (I'll use the fact that new commits don't generate emails as my excuse). |
This update resolves #1 - please accept.
Thanks,
Kent