Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UTF-8 characters in overlay_args #1

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

martinzamuner
Copy link
Owner

Using UTF-8 characters inside overlay_args generates different problems.

Case #1

link_to_overlay "Test", test_path, overlay_args: { title: "Test thís" }

raises an ArgumentError with invalid byte sequence in UTF-8.

Case #2

link_to_overlay "Test", test_path, overlay_args: { title: "✏️ Test" }

will simply behave as a non-overlay request.

@martinzamuner martinzamuner merged commit 5d47b87 into main Nov 4, 2022
@martinzamuner martinzamuner deleted the utf8-in-overlay-args branch November 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant