Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black error #168

Merged
merged 11 commits into from
May 24, 2021
Merged

Fix black error #168

merged 11 commits into from
May 24, 2021

Conversation

pieterhelsen
Copy link
Collaborator

When running an unsuccessful black format check the script automatically runs the formatter and commits the altered source code.

This currently results in an error:

Run black src tests
reformatted src/chia_log/log_consumer.py
All done! ✨ 🍰 ✨
1 file reformatted, 62 files left unchanged.
error: pathspec 'feature/improve-harvester-offline' did not match any file(s) known to git
Error: Process completed with exit code 1.

Adding git fetch potentially solves this error.

When running an unsuccessful `black` format check the script automatically runs the formatter and commits the altered source code.

This currently results in an error:
```
Run black src tests
reformatted src/chia_log/log_consumer.py
All done! ✨ 🍰 ✨
1 file reformatted, 62 files left unchanged.
error: pathspec 'feature/improve-harvester-offline' did not match any file(s) known to git
Error: Process completed with exit code 1.
```

Adding `git fetch` potentially solves this error.
Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that should do it.

Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think you'll want to run black after checking out the branch. I suggest also breaking the formatting somewhere to test it within this PR.

pieterhelsen and others added 10 commits May 23, 2021 11:18
Also added deliberate formatting mistake to trigger test
Revert due to failing workflow
Still getting 'waiting for checks information' in Github
Moved the black format check to the back of the queue, as it can be automatically fixed, while the others require manual intervention.

Also removed the `black --check` since we want to make the changes anyhow
@pieterhelsen pieterhelsen requested a review from martomi May 24, 2021 16:32
Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now I can contribute to the repository while sleeping 😄

@martomi martomi merged commit 756f7b6 into dev May 24, 2021
@martomi martomi deleted the bugfix/black-workflow branch May 24, 2021 16:44
jinnatar pushed a commit to jinnatar/chiadog that referenced this pull request Feb 5, 2023
When running an unsuccessful `black` format check the script automatically runs the formatter and commits the altered source code.

This currently results in an error:
```
Run black src tests
reformatted src/chia_log/log_consumer.py
All done! ✨ 🍰 ✨
1 file reformatted, 62 files left unchanged.
error: pathspec 'feature/improve-harvester-offline' did not match any file(s) known to git
Error: Process completed with exit code 1.
```

Moved the black format check to the back of the queue, as it can be automatically fixed, while the others require manual intervention.

Also removed the `black --check` since we want to make the changes anyhow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants