-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix black error #168
Fix black error #168
Conversation
When running an unsuccessful `black` format check the script automatically runs the formatter and commits the altered source code. This currently results in an error: ``` Run black src tests reformatted src/chia_log/log_consumer.py All done! ✨ 🍰 ✨ 1 file reformatted, 62 files left unchanged. error: pathspec 'feature/improve-harvester-offline' did not match any file(s) known to git Error: Process completed with exit code 1. ``` Adding `git fetch` potentially solves this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that should do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think you'll want to run black after checking out the branch. I suggest also breaking the formatting somewhere to test it within this PR.
Also added deliberate formatting mistake to trigger test
Revert due to failing workflow
Still getting 'waiting for checks information' in Github
Moved the black format check to the back of the queue, as it can be automatically fixed, while the others require manual intervention. Also removed the `black --check` since we want to make the changes anyhow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now I can contribute to the repository while sleeping 😄
When running an unsuccessful `black` format check the script automatically runs the formatter and commits the altered source code. This currently results in an error: ``` Run black src tests reformatted src/chia_log/log_consumer.py All done! ✨ 🍰 ✨ 1 file reformatted, 62 files left unchanged. error: pathspec 'feature/improve-harvester-offline' did not match any file(s) known to git Error: Process completed with exit code 1. ``` Moved the black format check to the back of the queue, as it can be automatically fixed, while the others require manual intervention. Also removed the `black --check` since we want to make the changes anyhow
When running an unsuccessful
black
format check the script automatically runs the formatter and commits the altered source code.This currently results in an error:
Adding
git fetch
potentially solves this error.