Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix _has_rotated windows powershell.exe #216

Merged
merged 3 commits into from
Jun 5, 2021
Merged

fix _has_rotated windows powershell.exe #216

merged 3 commits into from
Jun 5, 2021

Conversation

mezzovide
Copy link
Contributor

@mezzovide mezzovide commented Jun 1, 2021 •
edited
Loading

add missing ")"

@mezzovide mezzovide mentioned this pull request Jun 2, 2021
Closed
@pieterhelsen pieterhelsen linked an issue Jun 2, 2021 that may be closed by this pull request
Error when running remote windows harvester #208
Closed
pieterhelsen
pieterhelsen requested changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@pieterhelsen pieterhelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this bug! The first bracket is actually extraneous and can be removed.
f"powershell.exe Write-Host(Get-Item {str(path)}).length"

@mezzovide mezzovide requested a review from pieterhelsen June 3, 2021 14:06
@pieterhelsen pieterhelsen requested a review from martomi June 3, 2021 14:15
martomi
martomi approved these changes Jun 5, 2021
View reviewed changes
Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martomi martomi merged commit aa903c4 into martomi:main Jun 5, 2021
martomi pushed a commit that referenced this pull request Jun 5, 2021
@mezzovide @martomi
LogConsumer: Fix rotated log check on windows (#216)
3a6a882
@jiimbo420
Copy link

Thanks for fix

jinnatar pushed a commit to jinnatar/chiadog that referenced this pull request Feb 5, 2023
@mezzovide @martomi
LogConsumer: Fix rotated log check on windows (martomi#216)
e72a7ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martomi martomi martomi approved these changes

@pieterhelsen pieterhelsen pieterhelsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when running remote windows harvester
4 participants
@mezzovide @jiimbo420 @pieterhelsen @martomi