fix blockfound parser #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martomi
reviewed
Sep 18, 2021
| @@ -27,7 +27,7 @@ class BlockParser: | |||
| def __init__(self): | |||
| logging.info("Enabled parser for block found stats.") | |||
| self._regex = re.compile( | |||
| r"([0-9:.]*) full_node (?:src|chia).full_node.full_node\s*: INFO\s* ((?:🍀|.)\s* Farmed unfinished_block)" | |||
| r"([0-9:.]*) full_node (?:src|chia).full_node.full_node\s*: INFO\s* ((?:🍀 ️|.)\s*Farmed unfinished_block)" | |||
There was a problem hiding this comment.
Thanks for noticing this. What's this character after the 🍀? Looks like empty space but it's not. Otherwise \s* will cover it.
It'd be good if anyone else can confirm if they have that in their output before we merge this. Also adding an example log and test-case for that parser will prevent similar issues in future. Similar to already existing log tests
There was a problem hiding this comment.
Seems to be this character https://www.fileformat.info/info/unicode/char/fe0f/index.htm
martomi
previously approved these changes
Oct 4, 2021
martomi
pushed a commit
that referenced
this pull request
Jul 2, 2022
martomi
pushed a commit
that referenced
this pull request
Jul 2, 2022
* Tests: Add block found tests (#278) * Parsers: Fix block parser (#293) * Bugfix: Check for non MacOS operating systems before running apt-get * Add Pushcut notifier as an alternative to Pushover (#304) * Add IFTTT notifying functionality (#305) * Config: Toggle notifications for plot increases and decreases (#307) This commits adds new notification for plot increases (e.g connecting HDD) and makes the notifications for increases/decreases configurable via the config for every integration. * Add a sandboxed systemd service * Add a scripts/linux/chiadog.service systemd example that attempts to run chiadog in a more isolated environment. Create a new limited user each run (making much of the filesystem readonly), and set `.chia/mainnet` folders other than `log` to inaccessible. * Move the offset file - previously, the `debug.log.offset` file was kept in the chiadog directory, but when running in a read only filesystem we can't write there. Create a temporary directory when running, and store the offset file there. This also means we no longer need to delete the offset file on startup. * Add ~/.chia_keys to list of InaccessiblePaths in systemd Chia is [migrating their keyfiles](https://github.com/Chia-Network/chia-blockchain/wiki/Passphrase-Protected-Chia-Keys-and-Key-Storage-Migration) to `~/.chia_keys`. Block this folder from access in the systemd service. * Add config option to disable SMTP auth for basic postfix setup (#314) Sometimes it is useful to disable SMTP authentication for sending emails. For example, if someone is using a local postfix server, the default install doesn't require/enable auth. When this new config option is set to enable_smtp_auth: false, the username_smtp and password_smtp config options are ignored. * Add a transaction amount filter The filter was added primarily to deal with Chia dust storms which spam wallets with large amounts of transactions that contain tiny amounts of XCH. The configuration is done via an optional top level filter section in config.yaml with an initial transaction_amount to allow for additional future filter configurations. * Change config structure to handlers.wallet_added_coin_handler * Move documentation to config-example.yaml * Add log statement when a chia message gets filtered out * Add log statement/s when wallet_added_coin_handler is enabled plus refactor config checking * Add failing test Co-authored-by: Kyle Yee <kanasite@users.noreply.github.com> Co-authored-by: Connor Knabe <Connor-Knabe@users.noreply.github.com> Co-authored-by: Alex King <alexking@me.com> Co-authored-by: Pamela R. Hunt <90120449+unsocial-bleach@users.noreply.github.com>
martomi
pushed a commit
that referenced
this pull request
Jul 2, 2022
* Tests: Add block found tests (#278) * Parsers: Fix block parser (#293) * Bugfix: Check for non MacOS operating systems before running apt-get * Add Pushcut notifier as an alternative to Pushover (#304) * Add IFTTT notifying functionality (#305) * Config: Toggle notifications for plot increases and decreases (#307) This commits adds new notification for plot increases (e.g connecting HDD) and makes the notifications for increases/decreases configurable via the config for every integration. * Add a sandboxed systemd service * Add a scripts/linux/chiadog.service systemd example that attempts to run chiadog in a more isolated environment. Create a new limited user each run (making much of the filesystem readonly), and set `.chia/mainnet` folders other than `log` to inaccessible. * Move the offset file - previously, the `debug.log.offset` file was kept in the chiadog directory, but when running in a read only filesystem we can't write there. Create a temporary directory when running, and store the offset file there. This also means we no longer need to delete the offset file on startup. * Add ~/.chia_keys to list of InaccessiblePaths in systemd Chia is [migrating their keyfiles](https://github.com/Chia-Network/chia-blockchain/wiki/Passphrase-Protected-Chia-Keys-and-Key-Storage-Migration) to `~/.chia_keys`. Block this folder from access in the systemd service. * Add config option to disable SMTP auth for basic postfix setup (#314) Sometimes it is useful to disable SMTP authentication for sending emails. For example, if someone is using a local postfix server, the default install doesn't require/enable auth. When this new config option is set to enable_smtp_auth: false, the username_smtp and password_smtp config options are ignored. * Add a transaction amount filter The filter was added primarily to deal with Chia dust storms which spam wallets with large amounts of transactions that contain tiny amounts of XCH. The configuration is done via an optional top level filter section in config.yaml with an initial transaction_amount to allow for additional future filter configurations. * Change config structure to handlers.wallet_added_coin_handler * Move documentation to config-example.yaml * Add log statement when a chia message gets filtered out * Add log statement/s when wallet_added_coin_handler is enabled plus refactor config checking * Add failing test Co-authored-by: Kyle Yee <kanasite@users.noreply.github.com> Co-authored-by: Connor Knabe <Connor-Knabe@users.noreply.github.com> Co-authored-by: Alex King <alexking@me.com> Co-authored-by: Pamela R. Hunt <90120449+unsocial-bleach@users.noreply.github.com>
martomi
pushed a commit
that referenced
this pull request
Jul 2, 2022
jinnatar
pushed a commit
to jinnatar/chiadog
that referenced
this pull request
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martomi I farmed a pool block today realized the parser is not recognizing, I've updated the regex at least for ubuntu's log