Inhouse docker image builds #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, let me rebase this from dev -> main. |
This way it doesn't matter how configs are named.
This brings over only only drop dead simple bits that really should live with the tool itself. Major benefits: - Can easily build any state of the repo regardless of branch or mid-development into a functional image without mucking about with an external repo. - Faster builds when the source code is already present without an extra clone Minor fixes added as well: - entrypoint.sh was missing a shebang - Simplified entrypoint running now that the script has a proper shabang - Simplified logic by switching WORKDIR earlier - Add a .dockerignore file to prune dirty state and useless weight from the container. Does not include: - Any documentation. Docker is an advanced option in any case but this should be added as a followup. - Automated Docker builds. Those come in the next commit.
- Images based on the `main` branch will update the `latest` tag. - Other branches will be tagged with the branch name and first 6 chars of commit hash. - Any git tags will tag images as-is, say `v0.7.0` would become: `ghcr.io/martomi/chiadog:v0.7.0`
jinnatar
force-pushed
the
inhouse_docker
branch
from
e77f908 to
26c7b8b
Compare
|
Example image has been automatically built in my fork: https://github.com/Artanicus/chiadog/pkgs/container/chiadog .. this shows the logic for non-special branches with the image name becoming: |
martomi
reviewed
Jan 13, 2022
This reverts commit 5f2b542.
- Breaking change for anyone coming from ajacobson/chiadog-docker: The config dir env variable is now called CHIADOG_CONFIG_DIR - Switch base image to python:3.10-slim, reduced image size significantly - Dropped manual TZ handling at the container system level, just setting env TZ is enough - Dropped manual PyNaCL install, requirements pull in the binary wheel just fine - Simplify entrypoint and use sh for security.
|
@martomi PTAL, all feedback incorporated and everything simplified quite a bit. |
guydavis
added a commit
to guydavis/chiadog
that referenced
this pull request
Jan 20, 2022
Automated docker image builds (martomi#323)
jinnatar
added a commit
to jinnatar/chiadog
that referenced
this pull request
Feb 5, 2023
* Inhouse Dockerfile and entrypoint from ajacobson/chiadog-docker This brings over only only drop dead simple bits that really should live with the tool itself. Major benefits: - Can easily build any state of the repo regardless of branch or mid-development into a functional image without mucking about with an external repo. - Faster builds when the source code is already present without an extra clone Minor fixes added as well: - entrypoint.sh was missing a shebang - Simplified entrypoint running now that the script has a proper shabang - Simplified logic by switching WORKDIR earlier - Add a .dockerignore file to prune dirty state and useless weight from the container. Does not include: - Any documentation. Docker is an advanced option in any case but this should be added as a followup. - Automated Docker builds. Those come in the next commit. * Automate building of Docker images. - Images based on the `main` branch will update the `latest` tag. - Other branches will be tagged with the branch name and first 6 chars of commit hash. - Any git tags will tag images as-is, say `v0.7.0` would become: `ghcr.io/martomi/chiadog:v0.7.0` * Simplify & improve Docker image, change config env to CHIADOG_CONFIG_DIR - Breaking change for anyone coming from ajacobson/chiadog-docker: The config dir env variable is now called CHIADOG_CONFIG_DIR - Switch base image to python:3.10-slim, reduced image size significantly - Dropped manual TZ handling at the container system level, just setting env TZ is enough - Dropped manual PyNaCL install, requirements pull in the binary wheel just fine - Simplify entrypoint and use sh for security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hugely builds on the work by @ajacobson (https://github.com/ajacobson/chiadog-docker) and no disrespect is intended.
Proposing merge to
maininstead ofdevsince this does not in any way modify how Chiadog works and will then enable images to be built for any and all branches regardless of when dev is merged to main.Major benefits of inhousing:
mid-development into a functional image without mucking about with an
external repo. Doing other chiadog development made me frustrated enough to also fix this. :-)
Minor fixes added as well:
the container.
Does not include:
should be added as a followup.