Add Windows support for file read and interrupt. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool thanks! I'm going to push this into a minor release later today. |
|
I'd suggest to also add in a comment here example path for windows, with the correct slashes // \ |
|
All types of paths actually work I think, since they are resolved by the pathlib. I've added a comment regarding being absolute path though. |
martomi
reviewed
Apr 26, 2021
install.ps1
Outdated
| Invoke-expression "$($command) -m venv .venv" | ||
|
|
||
| # Create virtual environment | ||
| Invoke-expression "$($command) -m venv .venv" |
Closed
martomi
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Add Windows support for file read and interrupt. * Add install/start scripts for Windows and Linux
pieterhelsen
pushed a commit
to pieterhelsen/chiadog
that referenced
this pull request
May 9, 2021
* Add Windows support for file read and interrupt. * Add install/start scripts for Windows and Linux
jinnatar
pushed a commit
to jinnatar/chiadog
that referenced
this pull request
Feb 5, 2023
* Add Windows support for file read and interrupt. * Add install/start scripts for Windows and Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address any know issues so far for running on Windows described in #7