Improve cross-platform implementation #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the following changes to fix a Pathlib bug where the log file could not be found in the event of a Windows-run chiadog connecting to a remote Linux harvester: - Renamed `_get_remote_platform()` to `get_host_info()` and made it static. - Moved `get_host_info()` from class initializer to `create_log_consumer_from_config()` - Replaced `Path` with either `PosixPurePath` or `WindowsPurePath` depending on remote host OS info - Added line to `.gitignore` to allow multi-remote testing Updated `util.py` (code formatter output)
martomi
reviewed
May 1, 2021
Miscellaneous type hinting fixes
martomi
approved these changes
May 2, 2021
jinnatar
pushed a commit
to jinnatar/chiadog
that referenced
this pull request
Feb 5, 2023
Made the following changes to fix a Pathlib bug where the log file could not be found in the event of a Windows-run chiadog connecting to a remote Linux harvester: - Renamed `_get_remote_platform()` to `get_host_info()` and made it static. - Moved `get_host_info()` from class initializer to `create_log_consumer_from_config()` - Replaced `Path` with either `PosixPurePath` or `WindowsPurePath` depending on remote host OS info - Added line to `.gitignore` to allow multi-remote testing - Updated `util.py` (code formatter output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following changes to fix a Pathlib bug where the log file could not be found in the event of a Windows-run chiadog connecting to a remote Linux harvester:
Renamed
_get_remote_platform()toget_host_info()and made it static.Moved
get_host_info()from class initializer tocreate_log_consumer_from_config()Replaced
Pathwith eitherPosixPurePathorWindowsPurePathdepending on remote host OS infoAdded line to
.gitignoreto allow multi-remote testingAlso some minor updates
util.pyand log_consumer.py based on code formatter output