Escape special regex characters in library path scan #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprigent
approved these changes
May 5, 2020
There was a problem hiding this comment.
This should solve #377.
Code looks good, I'll try to give it a try this afternoon!
EDIT> Gave it a try, it does solve #377!
Thanks a lot @GilgameshxZero !
martpie
added a commit
that referenced
this pull request
May 25, 2022
Escape special regex characters in library path scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory path patterns passed to
globbymay contain special regex characters which will not parse correctly, leadingmuseeksto fail to scan some directories containing those characters. This PR escapes the regex characters in directory paths.The current (buggy) behavior is visible by creating a directory named
(test)((and)are special regex characters) and placing within it any.mp3file. Attempting to add the(test)directory to the library will not add any.mp3files within.The relevant special characters are
$^*+?()[]. More information is atfast-globandmicromatch.