+/- 10s audio seek with Arrow Keys #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Vega <josevega234@gmail.com>
mike-seger
approved these changes
Jun 21, 2021
|
@jvegaf thank you for the PR, sorry for the big delay for the review. Overall, it looks good, but I think you should add a safeguard for when we are typing in an input or something: Something like there: https://github.com/martpie/react-keybinding-component/blob/6688095b81dfe16c29798cc00e82ed28942e0a02/src/keybinding.tsx#L50 So maybe you can make use of the |
|
Oh my bad, it's already the case, let's go then! |
martpie
added a commit
that referenced
this pull request
May 25, 2022
+/- 10s audio seek with Arrow Keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #575
Seek +/- 10 sec with Arrow Keys