This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal (i.e. least changes possibe) typescript conversion. Once this is in we can go further, neatening up the code is far easier (ime) once you have a compiler to trust you're not breaking things by refactoring.
One caveat - there is a little bit of noise in the
awsData.ts
file - the few lines likeat the bottom of some of the interfaces should be unnecessary, but are required to work around the lack of microsoft/TypeScript#13195 .
EDIT - after testing with Node 4 I have changed a little bit more - now the tests are in a subfolder in
src
and are compiled along with the lib. This is not so much because the tests should be typescript, but instead because it makes requiring file paths all relative, and means we don't need to use ts-node (analogous to babel-node) anymore. These changes also make gulp unnecessary, so I've removed that too.