Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Typescript #72

Merged
merged 4 commits into from
Nov 13, 2017
Merged

Typescript #72

merged 4 commits into from
Nov 13, 2017

Conversation

akdor1154
Copy link
Contributor

@akdor1154 akdor1154 commented Nov 9, 2017

Minimal (i.e. least changes possibe) typescript conversion. Once this is in we can go further, neatening up the code is far easier (ime) once you have a compiler to trust you're not breaking things by refactoring.

One caveat - there is a little bit of noise in the awsData.ts file - the few lines like

    Type: undefined
    ItemType: undefined

at the bottom of some of the interfaces should be unnecessary, but are required to work around the lack of microsoft/TypeScript#13195 .

EDIT - after testing with Node 4 I have changed a little bit more - now the tests are in a subfolder in src and are compiled along with the lib. This is not so much because the tests should be typescript, but instead because it makes requiring file paths all relative, and means we don't need to use ts-node (analogous to babel-node) anymore. These changes also make gulp unnecessary, so I've removed that too.

@martysweet martysweet changed the base branch from master to development November 13, 2017 19:05
@martysweet
Copy link
Owner

martysweet commented Nov 13, 2017

Thanks @akdor1154. LGTM. I need to make a couple of changes re. CI, so I will merge this into Development and open a new PR for the V1.3.0 which should be released this week. Any further TypeScript additions/tweaks will be bug fix semver version increments.

@akdor1154
Copy link
Contributor Author

akdor1154 commented Nov 13, 2017

k, I'll rebase on development. EDIT ah never mind, you're too quick. :p
I have that big validation refactor nearly done as well, do you want to see that before you do a major version?

@martysweet
Copy link
Owner

Yeah, sounds like a plan

@martysweet martysweet merged commit 28299ff into martysweet:development Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants