chore: switching full screen components' height unit from vh to % #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nijuumaru ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I would presonally prefer to use dvh and fallback to vh if possible |
|
I guess we probably need a fallback for devices that doesn't support dvh? |
Yep, just not added yet, will do👌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mobile device, where the address bar of the browser may likely to be hiding during browsing the page, which makes
vhnot accurate when it is hiding.Using
dvhor%solves this problem, while for full screen element, I believe that they are the same with%more compatibleOr do you think it is safer to use
dvhinstead?