-
Notifications
You must be signed in to change notification settings - Fork 99
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is similar to 53e9d3e. Over at https://github.com/cockroachdb/cockroach, we use bazel and it chokes on this file: ``` java.io.IOException: Error extracting [...]/com_github_maruel_panicparse_v2-v2.2.1.zip to [...]: [...]/com_github_maruel_panicparse_v2/cmd/panic/internal/utf8/?tf8.go (Illegal byte sequence) ``` which is why we're on a fork so far. It would be nice to avoid this. There is an (eternal, it seems) [upstream discussion], so there is little home of bazel starting to support non-unicode filenames. I wonder if the loss in test coverage (if any) is acceptable in return for avoiding build problems like the ones we've been seeing. [upstream discussion]: bazelbuild/bazel#374
- Loading branch information
Showing
3 changed files
with
9 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters